Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Compatibility with Pilosa server/develop#105

Merged
yuce merged 9 commits intoFeatureBaseDB:developfrom
yuce:1345-compat
Jun 29, 2018
Merged

Compatibility with Pilosa server/develop#105
yuce merged 9 commits intoFeatureBaseDB:developfrom
yuce:1345-compat

Conversation

@yuce
Copy link
Contributor

@yuce yuce commented Jun 15, 2018

No description provided.

@yuce yuce requested a review from codysoyland June 15, 2018 11:51
@yuce
Copy link
Contributor Author

yuce commented Jun 19, 2018

ping!

@codysoyland
Copy link
Contributor

Hey Yuce, sorry for the delay on this. Are the CI failures due to running against master instead of develop?

@yuce
Copy link
Contributor Author

yuce commented Jun 22, 2018

@codysoyland Yeah, that's right.

@codysoyland
Copy link
Contributor

Have you run it against the new pql changes (just merged)? I ran pilosa server (with newest develop branch) and then PILOSA_BIND="http://:10101" LEGACY_MODE_OFF=true make test-all and I'm getting pilosa.client.PilosaServerError: Server error (406): JSON only acceptable response.

@yuce
Copy link
Contributor Author

yuce commented Jun 22, 2018

We used to set the Accept and Content-Type headers to protobuf since most of the handlers didn't care about those. I've removed the defaults and those headers are set only for query and import endpoints. There are missing failing tests for new PQL calls. I'll fix them and commit.

@yuce
Copy link
Contributor Author

yuce commented Jun 22, 2018

@yuce yuce closed this Jun 22, 2018
@yuce yuce reopened this Jun 22, 2018
@yuce
Copy link
Contributor Author

yuce commented Jun 22, 2018

Oops...

@yuce
Copy link
Contributor Author

yuce commented Jun 26, 2018

@codysoyland This branch works with the latestdevelop again.

@yuce yuce merged commit 306c42e into FeatureBaseDB:develop Jun 29, 2018
@yuce yuce deleted the 1345-compat branch June 29, 2018 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants